Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding python3 on the build image. #48

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Adding python3 on the build image. #48

merged 2 commits into from
Dec 6, 2023

Conversation

pacostas
Copy link
Contributor

Summary

This PR adds python3 dependency on the build image. python3 is a necessary dependency for building native modules during build process.

Use Cases

When in node_modules there is a package that has native code and needs to be built.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@pacostas pacostas requested a review from a team as a code owner November 21, 2023 12:39
mhdawson
mhdawson approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pacostas pacostas mentioned this pull request Nov 23, 2023
Merged
5 tasks
@TisVictress TisVictress added the semver:minor A change requiring a minor version bump label Dec 6, 2023
@TisVictress TisVictress merged commit 81e428e into paketo-buildpacks:main Dec 6, 2023
8 of 9 checks passed
@pacostas pacostas deleted the adding-python3 branch December 7, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@TisVictress TisVictress TisVictress approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacostas @mhdawson @TisVictress