Automation/GitHub config/update with fixed integration issues #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pacostas
force-pushed
the
automation/github-config/update
branch
from
478fa27 to
2a98cbd
Compare
thitch97
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is rebased on top of this one Updates github-config #42 in order to fix issues with the integration tests not running.
Is fully aligned with the one from node-engine, this one Updates github-config node-engine#771 and this one https://github.com/paketo-buildpacks/node-engine/blob/main/scripts/integration.sh
I also added integration tests running on the create-draft-release workflow, similar to what is being used in node-engine https://github.com/paketo-buildpacks/node-engine/blob/be44298c539941c80d1e8403c689343cf266eafc/.github/workflows/create-draft-release.yml#L40-L60
Checklist