Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create arm-create-package.yml #204

Closed
wants to merge 8 commits into from
Closed

Conversation

anthonydahanne
Copy link
Member

@anthonydahanne anthonydahanne commented Oct 18, 2023

This PR updates the pipeline builder create-package workflow automation to support multi-arch builds of this buildpack (ARM64 and AMD64). The ARM64 image should be considered experimental for now, since the official Paketo RFC and CNB RFCs related to multi-arch have not been merged in yet.
It uses an experimental version of the pack CLI (buildpacks/pack#2086), and is based off of the upstream CNB RFC that is currently IN PROGRESS. This workflow will definitely be subject to change when an official pack release comes out, and if there are any changes to the upstream RFC.
Once we have merged this and seen it work on main, we will contribute it into the upstream pipeline-builder repository.
(@sophiewigmore )

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner October 18, 2023 23:55
@anthonydahanne
Copy link
Member Author

this should be moved under pipeline builder, right @dmikusa ?

@dmikusa
Copy link
Contributor

dmikusa commented Dec 23, 2023

Yes, this is going to be a pipeline-builder change.

@dmikusa
Copy link
Contributor

dmikusa commented Jan 20, 2024

We've implemented some things in pipeline-builder, is this PR still needed?

@anthonydahanne
Copy link
Member Author

@dmikusa well, we don't "need" it, it's more like a playground to test arm64 package publication.

AFAIK, pipeline-builder does not support generating such a workflow, so this workflow should go in pipeline-builder and be generated as pb-create-package-arm64.yml when a

package:
  arm64: true

property is set.

Also, it won't be the end of it, we'll also need another pb-merge-manifest.yml that will push the dual arch buildpack

@anthonydahanne anthonydahanne force-pushed the anthonydahanne-arm64-tests branch 2 times, most recently from ea07850 to c1e64a4 Compare January 26, 2024 03:59
@dmikusa
Copy link
Contributor

dmikusa commented Jan 26, 2024

Gotcha, OK.

* all in on workflow: amd64, arm64, then merge them up and copy to secondary repo
* otherwise pack does not write the mandatory Architecture field
@anthonydahanne anthonydahanne force-pushed the anthonydahanne-arm64-tests branch 10 times, most recently from 5005b48 to f01b32c Compare March 12, 2024 19:39
@anthonydahanne anthonydahanne force-pushed the anthonydahanne-arm64-tests branch 8 times, most recently from ae1f1c6 to 0c0b745 Compare March 13, 2024 18:25
@anthonydahanne anthonydahanne added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Mar 13, 2024
* do not override tags with (ok with Crane) pack experimental
@sophiewigmore
Copy link
Member

Per convo with Anthony - we'll prob need to update some stuff in the buildpack.toml around the arch field for the dependencies. We will need libpak changes to work with that too, most likely.

@anthonydahanne anthonydahanne marked this pull request as draft March 16, 2024 00:58
@anthonydahanne anthonydahanne deleted the anthonydahanne-arm64-tests branch April 26, 2024 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants