-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create arm-create-package.yml #204
Conversation
this should be moved under pipeline builder, right @dmikusa ? |
Yes, this is going to be a pipeline-builder change. |
We've implemented some things in pipeline-builder, is this PR still needed? |
@dmikusa well, we don't "need" it, it's more like a playground to test AFAIK,
property is set. Also, it won't be the end of it, we'll also need another |
ea07850
to
c1e64a4
Compare
Gotcha, OK. |
ac0d868
to
a3a3a77
Compare
* all in on workflow: amd64, arm64, then merge them up and copy to secondary repo
* otherwise pack does not write the mandatory Architecture field
5005b48
to
f01b32c
Compare
ae1f1c6
to
0c0b745
Compare
0c0b745
to
33bc575
Compare
* do not override tags with (ok with Crane) pack experimental
3219625
to
2f00fdb
Compare
Per convo with Anthony - we'll prob need to update some stuff in the buildpack.toml around the |
This PR updates the pipeline builder create-package workflow automation to support multi-arch builds of this buildpack (ARM64 and AMD64). The ARM64 image should be considered experimental for now, since the official Paketo RFC and CNB RFCs related to multi-arch have not been merged in yet.
It uses an experimental version of the pack CLI (buildpacks/pack#2086), and is based off of the upstream CNB RFC that is currently IN PROGRESS. This workflow will definitely be subject to change when an official
pack
release comes out, and if there are any changes to the upstream RFC.Once we have merged this and seen it work on
main
, we will contribute it into the upstream pipeline-builder repository.(@sophiewigmore )
Checklist