Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Reduce Build Complexity of .Net Runtimes #219

Merged
merged 9 commits into from
Aug 2, 2022
Merged

Conversation

ForestEckhardt
Copy link
Contributor

@ForestEckhardt ForestEckhardt commented Jul 6, 2022

@ForestEckhardt ForestEckhardt added the team/dotnet-core .Net Core Subteam RFC label Jul 6, 2022
@ForestEckhardt ForestEckhardt requested a review from a team as a code owner July 6, 2022 19:18
@sophiewigmore
Copy link
Member

sophiewigmore commented Jul 7, 2022

@ForestEckhardt will this have any ramifications for the .NET Execute buildpack? The order groups will change in the language family as well right, where the new buildpack will go after .NET Publish? Are any of the provides/requires different?

@ForestEckhardt
Copy link
Contributor Author

@sophiewigmore I added something to the implementation section to outline requires changes that will happen. If you would like more detail just let me know and I will break it done further!

@fg-j
Copy link

fg-j commented Jul 7, 2022

Do we want to add the buildpack re-order to this RFC as well? (i.e run ASP.NET / Runtime installation after source code is compiled?) This is what's sketched out in my spike listed in the Prior Art.

@ForestEckhardt
Copy link
Contributor Author

@fg-j I think I would like to do this as a smaller chuck of work that would make the re-ordering easier to do in the future.

@sophiewigmore
Copy link
Member

IMO it would be nice to combine all of these concerns into one RFC

@ForestEckhardt
Copy link
Contributor Author

I have spent a little time looking at the re-architecture and I feel like I would just need to tack an additional RFC on to the end of this RFC that is contingent on this RFC passing. I am happy to do that but I think that the purposed re-architecture that @fg-j is purposing becomes a trivial RFC that can reference this RFC and the SDK RFC once they both pass. Please let me know you would like me know what y'all are feeling and I will go with the popular vote.

@fg-j
Copy link

fg-j commented Jul 7, 2022

+1 I'd like it all to happen in this RFC. Gives us an opportunity to evaluate if there are edge cases we're missing and how we could cover them.

@ForestEckhardt ForestEckhardt marked this pull request as draft July 12, 2022 15:58
@fg-j fg-j marked this pull request as ready for review July 25, 2022 15:50
@fg-j fg-j requested a review from sophiewigmore July 25, 2022 15:50
@joshuatcasey
Copy link
Contributor

2022-07-26 Working Group notes: waiting for approvals

Co-authored-by: Forest Eckhardt <feckhardt@pivotal.io>
@fg-j
Copy link

fg-j commented Aug 1, 2022

@paketo-buildpacks/dotnet-core-maintainers Am I good to merge this and get cracking on implementation?

@dmikusa
Copy link
Contributor

dmikusa commented Aug 2, 2022

2022-08-02 WG Notes:

Ready to merge.

@fg-j fg-j merged commit ccfbcb2 into main Aug 2, 2022
@fg-j fg-j deleted the simplify-dotnet-runtime branch August 2, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/dotnet-core .Net Core Subteam RFC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants