Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump docker/login-action@v1 to v2 #674

Merged
merged 1 commit into from
May 9, 2022
Merged

Bump docker/login-action@v1 to v2 #674

merged 1 commit into from
May 9, 2022

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented May 6, 2022

Summary

Reviewed changes upstream in the action and the major verison bump appears to be due to them increasing the minimum Node.js version required to run the action from 12 to 16. This was similar in other actions, causing a major bump but not changing config or functionality in the action itself.

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Reviewed changes upstream in the action and the major verison bump appears to be due to them increasing the minimum Node.js version required to run the action from 12 to 16. This was similar in other actions, causing a major bump but not changing config or functionality in the action itself.

Signed-off-by: Daniel Mikusa <dmikusa@vmware.com>
@dmikusa dmikusa added type:dependency-upgrade A dependency upgrade semver:patch A change requiring a patch version bump labels May 6, 2022
@dmikusa dmikusa requested a review from a team May 6, 2022 12:59
@dmikusa dmikusa merged commit ce70963 into main May 9, 2022
@dmikusa dmikusa deleted the bump-login-action branch May 9, 2022 18:07
This was referenced May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:dependency-upgrade A dependency upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant