Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arm64 update check issue #1433

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Fix arm64 update check issue #1433

merged 1 commit into from
Jan 18, 2024

Conversation

dmikusa
Copy link
Contributor

@dmikusa dmikusa commented Jan 18, 2024

Summary

This PR adds another jq selector to the query which is running to fetch the old version from buildpack.toml. Previously, this would return two version numbers, one for each version, and that casued a failure in the pipeline. With the additional selector, we get one version, the version for that specific architecture.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

This PR adds another `jq` selector to the query which is running to fetch the old version from buildpack.toml. Previously, this would return two version numbers, one for each version, and that casued a failure in the pipeline. With the additional selector, we get one version, the version for that specific architecture.

Signed-off-by: Daniel Mikusa <dan@mikusa.com>
@dmikusa dmikusa added type:bug A general bug semver:patch A change requiring a patch version bump labels Jan 18, 2024
@dmikusa dmikusa requested a review from a team as a code owner January 18, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump type:bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants