Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #111: Amazon Corretto actions adds source #1322

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

anthonydahanne
Copy link
Member

@anthonydahanne anthonydahanne commented Oct 6, 2023

  • using the Github API TarballURL; source code that matches what was used to build the jdk

Summary

with
INPUT_GLOB=amazon-corretto-[\d.-]+-linux-x64.tar.gz;INPUT_REPOSITORY=corretto-21

we got
UPDATED

sha256<<52b77679c43378f9b3cc4e8cedac648b
1b7ae2cabb15b69867511a08e0091bd2e2df67064ff444bbe883900819801e4b
52b77679c43378f9b3cc4e8cedac648b
uri<<52b77679c43378f9b3cc4e8cedac648b
https://corretto.aws/downloads/resources/21.0.0.35.1/amazon-corretto-21.0.0.35.1-linux-x64.tar.gz
52b77679c43378f9b3cc4e8cedac648b
version<<52b77679c43378f9b3cc4e8cedac648b
21.0.0
52b77679c43378f9b3cc4e8cedac648b
source_sha256<<52b77679c43378f9b3cc4e8cedac648b
caa78c398f8daa4577197b2354c3317a4e26b8c7b8eeff95b8e6fbfe44a48f72
52b77679c43378f9b3cc4e8cedac648b
source<<52b77679c43378f9b3cc4e8cedac648b
https://github.com/corretto/corretto-21/archive/refs/tags/21.0.0.35.1.tar.gz
52b77679c43378f9b3cc4e8cedac648b


Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@anthonydahanne anthonydahanne requested a review from a team as a code owner October 6, 2023 19:18
@anthonydahanne anthonydahanne added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Oct 6, 2023
@pivotal-david-osullivan
Copy link
Contributor

I didn't know about this Tarball URL in the API - I was about to switch to this for the Github Release action in #1325, but I checked the docs in case and it says

Note: For private repositories, these links are temporary and expire after five minutes.

Could this be a problem? In other Github-based source actions, I've been using a URL like https://github.com/%s/%s/archive/refs/tags/%s.tar.gz passing in the owner, repo & tag name to build it.

@anthonydahanne
Copy link
Member Author

Could this be a problem?

Although we only deal with public repositories, I believe your URL is more reliable than the Tarball URL I used, updating

@anthonydahanne anthonydahanne changed the title Issue #111: Aamazon Corretto actions adds source Issue #111: Amazon Corretto actions adds source Oct 12, 2023
* using the Github API TarballURL; source code that matches what was used to build the jdk
@anthonydahanne
Copy link
Member Author

Please @pivotal-david-osullivan have a look at the updated output; with the new source url
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants