Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version filtering to the NPM action #1055

Closed
dmikusa opened this issue Mar 17, 2023 · 0 comments · Fixed by paketo-community/rust-dist#229, paketo-buildpacks/procfile#171, paketo-buildpacks/health-checker#46, paketo-buildpacks/pipeline-builder-canary#160 or paketo-buildpacks/sbt#223
Closed

Add version filtering to the NPM action #1055

dmikusa opened this issue Mar 17, 2023 · 0 comments · Fixed by paketo-community/rust-dist#229, paketo-buildpacks/procfile#171, paketo-buildpacks/health-checker#46, paketo-buildpacks/pipeline-builder-canary#160 or paketo-buildpacks/sbt#223
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement

Comments

@dmikusa
Copy link
Contributor

dmikusa commented Mar 17, 2023

Describe the Enhancement

The action to fetch dependencies from NPM does not have a version filter. In some cases, we want to filter by version because there might be pre-release software or because we want to support multiple branches.

Possible Solution

Add a regex-based version filter.

Motivation

See description above.
@dmikusa dmikusa added type:enhancement A general enhancement note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with labels Mar 17, 2023
dmikusa added a commit that referenced this issue Mar 17, 2023
@dmikusa
Merge pull request #1056 from anthonydahanne/fix-1055-npm-version
ed82d63 
Closes #1055: Add version filtering to NPM action
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
Merged
@buildpack-bot buildpack-bot mentioned this issue Mar 22, 2023
Merged
@paketo-bot paketo-bot mentioned this issue Mar 22, 2023
Merged
@buildpack-bot buildpack-bot mentioned this issue Mar 22, 2023
Merged
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
@buildpack-bot buildpack-bot mentioned this issue Mar 22, 2023
Merged
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Mar 22, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@paketo-bot paketo-bot mentioned this issue Apr 7, 2023
Closed
@anthonydahanne anthonydahanne added the hacktoberfest Hacktoberfest eligible label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest Hacktoberfest eligible note:good-first-issue A good first issue to get started with note:ideal-for-contribution An issue that a contributor can help us with type:enhancement A general enhancement
Projects
None yet
Milestone
No milestone
2 participants
@anthonydahanne @dmikusa