Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for nginx order group #10

Merged
merged 7 commits into from
Apr 7, 2022
Merged

Add support for nginx order group #10

merged 7 commits into from
Apr 7, 2022

Conversation

robdimsdale
Copy link
Member

@robdimsdale robdimsdale commented Mar 30, 2022 •
edited
Loading

Signed-off-by: Sophie Wigmore swigmore@vmware.com

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale
Add support for nginx order group
d1b428d 
- integration test passing
- build tests passing
- detect tests passing
- README

Signed-off-by: Sophie Wigmore <swigmore@vmware.com>
@robdimsdale
Copy link
Member Author

robdimsdale commented Mar 30, 2022 •
edited
Loading

This is blocked on a release of php-nginx being available - the integration tests will fail until then.

robdimsdale
robdimsdale commented Mar 30, 2022
View reviewed changes
build.go Outdated Show resolved Hide resolved
@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label Mar 31, 2022
@sophiewigmore sophiewigmore added status/blocked This issue has been triaged and resolving it is blocked on some other issue and removed status/blocked This issue has been triaged and resolving it is blocked on some other issue labels Apr 1, 2022
@sophiewigmore sophiewigmore requested review from a team, sophiewigmore and paketo-bot-reviewer and removed request for a team April 5, 2022 14:10
@sophiewigmore sophiewigmore requested a review from a team April 5, 2022 14:47
thitch97
thitch97 reviewed Apr 6, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
integration/httpd_test.go Show resolved Hide resolved
sophiewigmore and others added 2 commits April 6, 2022 17:44
@sophiewigmore @thitch97
Update README.md
9a392f2 
Co-authored-by: Tim Hitchener <thitch97@users.noreply.github.com>
@sophiewigmore @thitch97
Update README.md
bb5f534 
Co-authored-by: Tim Hitchener <thitch97@users.noreply.github.com>
@thitch97 thitch97 merged commit c9683bd into paketo-buildpacks:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thitch97 thitch97 thitch97 approved these changes

@sophiewigmore sophiewigmore Awaiting requested review from sophiewigmore sophiewigmore is a code owner automatically assigned from paketo-buildpacks/php-maintainers

@paketo-bot-reviewer paketo-bot-reviewer Awaiting requested review from paketo-bot-reviewer paketo-bot-reviewer is a code owner automatically assigned from paketo-buildpacks/php-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robdimsdale @thitch97 @sophiewigmore