Adds support of buildpackages in buildpack store and updates freezer #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdimsdale
previously approved these changes
Jun 4, 2024
packagers/jam.go
Outdated
| @@ -47,15 +68,32 @@ func (j Jam) Execute(buildpackDir, output, version string, offline bool) error { | |||
| args := []string{ | |||
| "pack", | |||
| command, filepath.Join(buildpackDir, buildpackOrExtensionToml), | |||
| "--output", output, | |||
| "--output", filepath.Join(jamOutput, fmt.Sprintf("%s.tgz", version)), | |||
There was a problem hiding this comment.
can we encapsulate fmt.Sprintf("%s.tgz", version) into a variable - both for re-use but also to give it a useful name
There was a problem hiding this comment.
Sure I have no objections. Push something up soon.
| pack = &fakes.Executable{} | ||
|
|
||
| tempOutput = func(string, string) (string, error) { | ||
| return "some-jam-output", nil |
There was a problem hiding this comment.
Does this work if the tests are run in parallel?
I was expecting to see t.TempDir as a testing substitute for the default os.MkdirTemp
There was a problem hiding this comment.
I don't think I have ever seen issues with os.MkdirTemp and thread safety. It was just the function that I am most familiar with.
robdimsdale
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist