Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testdata must not use NodeJS 16 anymore #713

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Testdata must not use NodeJS 16 anymore #713

merged 1 commit into from
Jun 20, 2024

Conversation

c0d1ngm0nk3y
Copy link
Contributor

see #688 (comment)

Summary

The testdata has been changed use nodejs 18.

Use Cases

nodejs 16 is no longer available.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner June 20, 2024 12:42
@c0d1ngm0nk3y c0d1ngm0nk3y mentioned this pull request Jun 20, 2024
Merged
5 tasks
@c0d1ngm0nk3y c0d1ngm0nk3y added the semver:patch A change requiring a patch version bump label Jun 20, 2024
mhdawson
mhdawson approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson mhdawson merged commit 39ee53a into main Jun 20, 2024
10 of 11 checks passed
@mhdawson mhdawson deleted the integration-tests-node16 branch June 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@thitch97 thitch97 Awaiting requested review from thitch97 thitch97 is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@brayanhenao brayanhenao Awaiting requested review from brayanhenao brayanhenao is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0d1ngm0nk3y @mhdawson