Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use more shared functions in libnodejs #522

Merged
merged 3 commits into from
Jul 26, 2023
Merged

Use more shared functions in libnodejs #522

merged 3 commits into from
Jul 26, 2023

Conversation

mhdawson
Copy link
Member

Summary

Use Cases

  • use shared functions instead of local duplicates

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

mhdawson added 2 commits July 13, 2023 13:54
@mhdawson
use function in libnodejs to get project path
627cd6a 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson
use shared funcs to get version from package.json
714a269 
Remove copy of package.json parser and use shared
functions in libnodejs to parse package.json and
to get the version.

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson mhdawson requested a review from a team as a code owner July 13, 2023 18:11
@mhdawson mhdawson requested review from ryanmoran and thitch97 July 13, 2023 18:11
TisVictress
TisVictress previously approved these changes Jul 26, 2023
View reviewed changes
@TisVictress TisVictress added the semver:minor A change requiring a minor version bump label Jul 26, 2023
@TisVictress TisVictress merged commit 5060900 into paketo-buildpacks:main Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TisVictress TisVictress TisVictress approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@thitch97 thitch97 Awaiting requested review from thitch97 thitch97 is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhdawson @TisVictress