Rebuild with cached dependencies #393
Conversation
pbusko
force-pushed
the
rebuild-with-cached-dependencies
branch
from
94fdd61 to
f6ecd94
Compare
c0d1ngm0nk3y
force-pushed
the
rebuild-with-cached-dependencies
branch
from
f6ecd94 to
af02e36
Compare
build.go
Outdated
| if err != nil { | ||
| return packit.BuildResult{}, err | ||
| } | ||
| } | ||
| } | ||
|
|
||
| layer.Cache = true |
There was a problem hiding this comment.
We shouldn't need to set the cache flag on a launch layer. In this case, I believe the issue is that we've moved the layer.ExecD assignment outside of the if run conditional block which means it gets set on every run. Then, without the cache flag set, the exec.d binary getting written to the layer wipes out the previous contents. If you move the layer.ExecD setting back to its original location, then you can remove this flag.
There was a problem hiding this comment.
@ryanmoran Thanks for the review. Are you sure about the original location, though? Originally, it was located at launch>run>build, but with that some caching test (vendored) fail. I moved it to launch>run and the test succeeds and I removed the layer.Cache=true. WDYT?
c0d1ngm0nk3y
force-pushed
the
rebuild-with-cached-dependencies
branch
2 times, most recently
from
c4027fc to
ce495f3
Compare
- Introducing NODE_PROJECT_PATH to create correct symlinks at launch time Co-authored-by: Philipp Stehle <philipp.stehle@sap.com> Co-authored-by: Pavel Busko <pavel.busko@sap.com> Co-authored-by: Ralf Pannemans <ralf.pannemans@sap.com>
modulo11
force-pushed
the
rebuild-with-cached-dependencies
branch
from
ce495f3 to
0c6e911
Compare
Summary
As reported in the #375, if an app has only
package-lock.jsonand nonode_modulesfolder, after the rebuild thenode_modulessymlink from the workspace will point to non-existent build layer, instead of launch layer. Also the launch layer was not cached, which resulted in missing node_modules at all.Another issue which is fixed in scope of that PR, is that if the
BP_NODE_PROJECT_PATHis set, thesetup-symlinkswould fail, since there's no symlink in the working directory. Fixed by exposing project path as a launch environment variableNODE_PROJECT_PATHPotentially contains a fix for #342
Checklist