Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make projectPath group-writable #362

Merged
merged 3 commits into from
Jun 1, 2022
Merged

Make projectPath group-writable #362

merged 3 commits into from
Jun 1, 2022

Conversation

thitch97
Copy link
Contributor

@thitch97 thitch97 commented May 17, 2022

Summary

Makes the projectPath group-writable at the end of the build phase.

Use Cases

Resolves #355

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@thitch97 thitch97 requested a review from a team as a code owner May 17, 2022 18:43
@thitch97
Copy link
Contributor Author

thitch97 commented May 17, 2022

I have been able to do integration testing on this locally but have opted to hold off on including integration tests here until a consensus is reached on how to properly test stacks with different build and run uids. Separate issue & PR will follow.

@thitch97 thitch97 added the semver:patch A change requiring a patch version bump label May 17, 2022
@g-suraj
Copy link

g-suraj commented May 26, 2022

Anything in particular holding this PR from being approved/merged? Seems like it's good to go

@thitch97
Copy link
Contributor Author

Anything in particular holding this PR from being approved/merged? Seems like it's good to go

@g-suraj A couple things, yes. My fellow subteam maintainer is out for another week or so and this will require their approval. There were also concerns over whether this approach goes against the intentions of the Secure Runtime Environments RFC in its permissiveness but that isn't necessarily an outright blocker.

build.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A change requiring a patch version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different run-image and build-image users causing runtime failure
4 participants