Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use libnodejs function to resolve nodejs version #688

Merged
merged 1 commit into from
Aug 2, 2023
Merged

use libnodejs function to resolve nodejs version #688

merged 1 commit into from
Aug 2, 2023

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Aug 1, 2023 •
edited
Loading

Summary

Use function added to libnodejs in paketo-buildpacks/libnodejs#14

Use Cases

Use shared functionality from libnodejs where possible

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@mhdawson
use libnodejs function to resolve nodejs version
5558006 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
@mhdawson mhdawson requested a review from a team as a code owner August 1, 2023 17:51
@mhdawson mhdawson mentioned this pull request Aug 1, 2023
Closed
5 tasks
@TisVictress TisVictress added the semver:minor A change requiring a minor version bump label Aug 2, 2023
@TisVictress TisVictress merged commit 94509e9 into paketo-buildpacks:main Aug 2, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TisVictress TisVictress TisVictress approved these changes

@ryanmoran ryanmoran Awaiting requested review from ryanmoran ryanmoran is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

@thitch97 thitch97 Awaiting requested review from thitch97 thitch97 is a code owner automatically assigned from paketo-buildpacks/nodejs-maintainers

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhdawson @TisVictress