Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default instead of override for Gem path env var. #524

Merged
merged 1 commit into from
May 2, 2023
Merged

Use default instead of override for Gem path env var. #524

merged 1 commit into from
May 2, 2023

Conversation

robdimsdale
Copy link
Member

Summary / Use Cases

This PR sets the GEM_PATH environment variable to default instead of override so that users can override it if necessary. See paketo-buildpacks/rfcs#64

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@robdimsdale
Use default instead of override for Gem path env var.
b9f7bd9 
- to allow users to override it if necessary.
@robdimsdale robdimsdale requested a review from a team as a code owner May 2, 2023 19:41
@robdimsdale robdimsdale added the semver:minor A change requiring a minor version bump label May 2, 2023
@sophiewigmore sophiewigmore merged commit 277951b into main May 2, 2023
@sophiewigmore sophiewigmore deleted the gem-path-default branch May 2, 2023 20:37
@sophiewigmore sophiewigmore mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robdimsdale @sophiewigmore