Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only rely on shasum for dependency cache hit #266

Merged

Conversation

c0d1ngm0nk3y
Copy link
Contributor

fixes #233, like proposed here, let's do this change in the next major update. It is not breaking, but it will change the behaviour in a subtle way. Before, it was possible that the very same dependency was downloaded again.

Summary

When checking if some dependency can be reused, it should be enough to check the shasum. There is no need to verify that the metadata is the same (the binary is).

Use Cases

This caused cache misses when the metadata was different (e.g. DeprecationDate).

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@c0d1ngm0nk3y c0d1ngm0nk3y requested a review from a team as a code owner July 7, 2023 10:07
@anthonydahanne
Copy link
Member

hello @c0d1ngm0nk3y
I just noticed your PR, and unfortunately I previously merged a significant change in release-2.x : #265

Can you please rebase on top of release-2.x please?
Thank you!

@dmikusa dmikusa added type:enhancement A general enhancement semver:minor A change requiring a minor version bump labels Jul 25, 2023
@c0d1ngm0nk3y
Copy link
Contributor Author

I have updated the branch. Any comments?

@dmikusa dmikusa merged commit e071b20 into paketo-buildpacks:release-2.x Jul 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants