Do not check DeprecationDate when comparing dependencies #240
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This might be an alternative to #233 in addressing short comings when comes to comparing the metadata of a dependency.
DeprecationDate
does not work withreflect.deepEqual
for 2 reasonsMarshal
andUnmarshal
, thetime.Time
cannot be compared anymore, since it will loose some precision because of the missingUnmarshalTOML
reflect.deepEqual
will still fail because it compares the exact internal structure.CPEs
array is empty, those a arrays are not considered to bereflect.deepEqual
Use Cases
As discussed in #233, comparing the metadata of a dependency is probably not needed at all if
sha256
is the same. But at least the comparison should be successful in those cases since the dependency caching currently depends on it.Checklist