Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When using jlink, we can't use --add-modules ALL-MODULE-PATH #252

Closed
anthonydahanne opened this issue Feb 25, 2023 · 0 comments
Closed

When using jlink, we can't use --add-modules ALL-MODULE-PATH #252

anthonydahanne opened this issue Feb 25, 2023 · 0 comments

Comments

@anthonydahanne
Copy link
Member

copy issue paketo-buildpacks/bellsoft-liberica#350

To allow PRs to reference this one, since the fix will be happening in this repository
anthonydahanne added a commit to anthonydahanne/libjvm that referenced this issue Feb 25, 2023
@anthonydahanne
Close paketo-buildpacks#252 : Disable ToLower in some cases
96df4cb 
* if an argument is named "--add-modules", next argument must not be lowered case
anthonydahanne added a commit to anthonydahanne/libjvm that referenced this issue Mar 7, 2023
@anthonydahanne
Close paketo-buildpacks#252 : Disable ToLower in some cases
6af86c2 
* use lowercase to perform the comparison, and keep the original passed
  as an argument
anthonydahanne added a commit to anthonydahanne/libjvm that referenced this issue Mar 7, 2023
@anthonydahanne
Close paketo-buildpacks#252 : Disable ToLower in some cases
a78aebe 
* use lowercase to perform the comparison, and keep the original passed
  as an argument
anthonydahanne added a commit to anthonydahanne/libjvm that referenced this issue Mar 10, 2023
@anthonydahanne @dmikusa
Close paketo-buildpacks#252: use the short variable declaration
7f1194e 
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
anthonydahanne added a commit to anthonydahanne/libjvm that referenced this issue Mar 10, 2023
@anthonydahanne @dmikusa
Close paketo-buildpacks#252: use the short variable declaration
625cc92 
Co-authored-by: Daniel Mikusa <dan@mikusa.com>
dmikusa added a commit that referenced this issue Mar 10, 2023
@dmikusa
Merge pull request #253 from anthonydahanne/fix-252-jlink-caps
fc6777a 
Close #252 : Disable ToLower in some cases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonydahanne