Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable verbose gc logging #285

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

hibell
Copy link
Contributor

@hibell hibell commented Oct 11, 2022

Summary

Enable verbose GC logging when using the OpenJ9 JVM.

Use Cases

Verbose GC logging has a very low overhead and is useful if there are any high heap issues. @kevin-ortega can provide more details on this feature if you have any questions.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@hibell hibell requested a review from a team October 11, 2022 20:38
@hibell hibell marked this pull request as draft October 12, 2022 21:35
@hibell hibell marked this pull request as ready for review October 13, 2022 03:27
@dmikusa dmikusa added semver:minor A change requiring a minor version bump type:enhancement A general enhancement labels Oct 24, 2022
Copy link
Contributor

@dmikusa dmikusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good. Only thing is the extra Executor. I don't think that is necessary but let me know if you hit an issue and required that. Thanks!

cmd/main/main.go Outdated Show resolved Hide resolved
The logging is very low overheard and is valuable if there is any high heap usage.
@dmikusa dmikusa merged commit 86d8c64 into paketo-buildpacks:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:minor A change requiring a minor version bump type:enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants