Disambiguate Error type in TryFrom #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI errors on nightly seem unrelated to me, but let me know if there's anything I can do about that. |
|
Thanks for this! I agree that the CI failures are unrelated. I'll go ahead and merge this, then fix the CI failures and make a release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use
subenumon an enum containing a variant namedError,I got a compiler error, helpfully pointing me to this issue: rust-lang/rust#57644
This is due to the
TryFromimplementation generated by subenum, where it is now ambiguous whetherSelf::Errorrefers to the associated typeTryFrom::Erroror to the enum variantError.This PR fixes this by disambiguating in the return type of
try_from.