Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimensioned rewrite #21

Merged
merged 62 commits into from
Mar 3, 2017
Merged

Dimensioned rewrite #21

merged 62 commits into from
Mar 3, 2017

Conversation

paholg
Copy link
Owner

@paholg paholg commented Nov 3, 2016

I am opening this pull request for a couple reasons.

First, it is nearly complete, and I feel really good about this new version of dimensioned, but I would appreciate extra eyeballs taking a look.

Second, as tracking for what still needs to be done:

  • The make_units macro. I would like to restructure it somewhat to make its use more flexible.
  • Unit systems. For the unit systems we have, they need more constants defined and From implemented for conversions. It would also be nice to add more--at least one fully implemented imperial system.
  • The macro for making derived units needs some love.
  • Unit tests. We have almost none right now.
  • Fix the Root issue.
  • Make root functions only defined when modulo is zero.
  • Impl fmt traits for cgs, mks.
  • Add dimensions to macro
  • Eliminate fixmes

Documentation:

  • Lib doc
  • Unit systems
  • Conversion example
  • Prefixes
  • Traits
  • Add constant descriptions to unit system doc
  • make_units!
  • readme
  • changelog

@paholg paholg changed the title Dimensioned rewrite. Dimensioned rewrite Feb 27, 2017
@paholg paholg merged commit a1102a1 into master Mar 3, 2017
@paholg paholg deleted the rmdim branch March 3, 2017 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant