Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: [IOCOM-1891] Use 3xx responses as success type fallback #330

Merged
merged 1 commit into from
Oct 22, 2024
Merged

BREAKING CHANGE: [IOCOM-1891] Use 3xx responses as success type fallback #330

merged 1 commit into from
Oct 22, 2024

Conversation

lucacavallaro
Copy link
Member

Description

Now renderDecoderCode, if no 2xx response is found, checks for responses with status codes starting with "3" (indicating redirection).

Motivation and Context

The gen-api-models command expects each endpoint to have at least one successful (2xx) response - this is not always true, because some endpoints can returns a redirection response (3xx) on success.

How Has This Been Tested?

Unit test

Screenshots (if appropriate):

Types of changes

  • Chore (improvement with no change in the behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@lucacavallaro lucacavallaro requested a review from a team as a code owner October 22, 2024 09:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOCOM-1891

hevelius
hevelius approved these changes Oct 22, 2024
View reviewed changes
Copy link

@hevelius hevelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gunzip
gunzip previously requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@gunzip gunzip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to bump package.json version

@gunzip gunzip self-requested a review October 22, 2024 09:23
acuiuli
acuiuli approved these changes Oct 22, 2024
View reviewed changes
Copy link

@acuiuli acuiuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucacavallaro lucacavallaro merged commit 72bc5ac into master Oct 22, 2024
5 checks passed
@lucacavallaro lucacavallaro deleted the IOCOM-1891-use-3xx-as-success-type-fallback branch October 22, 2024 09:30
@lucacavallaro lucacavallaro changed the title [BREAKING CHANGE: [IOCOM-1891] Use 3xx responses as success type fallback BREAKING CHANGE: [IOCOM-1891] Use 3xx responses as success type fallback Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acuiuli acuiuli acuiuli approved these changes

@hevelius hevelius hevelius approved these changes

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

@giuseppedipinto giuseppedipinto Awaiting requested review from giuseppedipinto giuseppedipinto is a code owner automatically assigned from pagopa/io-backend-contributors

@gunzip gunzip Awaiting requested review from gunzip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucacavallaro @gunzip @hevelius @acuiuli