Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOCIT-104] working environment for profile data DOWNLOAD/DELETE #61

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

arcogabbo
Copy link
Contributor

@arcogabbo arcogabbo commented Aug 19, 2022

List of Changes

Updated @zeit/cosmosdb-server from 0.7.0 to 0.13.4 to introduce the composite index feature
Added extra-hosts rule to docker-compose.yaml to let host.docker.internal work as intended
Updated io-backend env variables to let /notify endpoint work from the start
Added io-fixture AUTHORIZED_RECIPIENTS env variable to parametrize the recipients in the services generated
Fixed io-functions-app-messages env variables to let it run
Fixed io-functions-admin env variables
Fixed io-functions-services duplicated env variables

Motivation and Context

Set up a working environment for profile data DOWNLOAD/DELETE flows

How Has This Been Tested?

DOWNLOAD and DELETE procedures tested

Screenshots (if appropriate):

Types of changes

  • Chore (nothing changes by a user perspective)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@@ -98,7 +98,7 @@ APP_MESSAGES_API_URL=http://functions-app-messages:7071/api/v1

FF_MESSAGES_TYPE="prod"
FF_MESSAGES_BETA_TESTER_LIST=""
FF_MESSAGES_CANARY_USERS_REGEX= "^([(0-9)|(a-f)|(A-F)]{63}0)|([(0-9)|(a-f)|(A-F)]{62}[(0-7)]{1}1)$"
FF_MESSAGES_CANARY_USERS_REGEX= "^([(0-9)|(a-f)|(A-F)]{63}0)|([(0-9)|(a-f)|(A-F)]{62}[(0-7)]{1}1)\$"
Copy link
Contributor Author

@arcogabbo arcogabbo Aug 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The error here was Invalid template: "^([(0-9)|(a-f)|(A-F)]{63}0)|([(0-9)|(a-f)|(A-F)]{62}[(0-7)]{1}1)$" from docker-compose.
This could be related

Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart a little improvement for IS_APPBACKENDLI behavior documentation.

@@ -121,7 +121,7 @@ THIRD_PARTY_CONFIG_LIST=""
# ------------------------------------
# APPBACKENDLI
# ------------------------------------
IS_APPBACKENDLI=false
IS_APPBACKENDLI=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. This was the reason because the /notify endpoint and /lock session endpoints returns 404. Documentation over this variable is not sufficient in here and into io-backend. We should remember to update the README in io-backend to explicit more this functionality behavior.
cc. @gquadrati

@BurnedMarshal BurnedMarshal merged commit 91929c1 into master Aug 22, 2022
@BurnedMarshal BurnedMarshal deleted the IOCIT-104-fix-for-profile-download-delete branch August 22, 2022 08:48
gquadrati added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants