Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOCOM-2187] Remove unused code for payments on messages #6765

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

Short description

This PR removes unused code on payments for message details.

List of changes proposed in this pull request

  • Removed unused code

How to test

Using the io-dev-api-server, check that a payment linked to a message can be:

  • unpaid (successful response)
  • paid (error response with PAA_PAGAMENTO_DUPLICATO and PPT_PAGAMENTO_DUPLICATO)
  • ongoing (error response with PAA_PAGAMENTO_IN_CORSO and PPT_PAGAMENTO_IN_CORSO)
  • revoked (error response with PAA_PAGAMENTO_ANNULLATO)
  • expired (error response with PAA_PAGAMENTO_SCADUTO)
  • a generic error

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link
Contributor

github-actions bot commented Feb 27, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.55%. Comparing base (04d2853) to head (3b77a47).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6765      +/-   ##
==========================================
- Coverage   51.09%   47.55%   -3.54%     
==========================================
  Files        1583     1580       -3     
  Lines       32710    32587     -123     
  Branches     7404     7324      -80     
==========================================
- Hits        16712    15496    -1216     
- Misses      15952    17044    +1092     
- Partials       46       47       +1     
Files with missing lines Coverage Δ
ts/utils/payment.ts 91.37% <ø> (+28.06%) ⬆️

... and 110 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22d8c7...3b77a47. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant