Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [IOCOM-2160] Service button accessibility role in message details #6758

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Feb 26, 2025

Short description

This PR fixes the accessibility role of the service button, in the message details' screen.

List of changes proposed in this pull request

  • Added "button" accessibility role

How to test

Using a real device (both Android and iOS), check that the service link is announced with the "button" role, on the message details' screen.

Copy link
Contributor

github-actions bot commented Feb 26, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.08%. Comparing base (04d2853) to head (c444c3e).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6758      +/-   ##
==========================================
- Coverage   51.09%   51.08%   -0.01%     
==========================================
  Files        1583     1583              
  Lines       32710    32709       -1     
  Branches     7404     7355      -49     
==========================================
- Hits        16712    16711       -1     
  Misses      15952    15952              
  Partials       46       46              
Files with missing lines Coverage Δ
.../components/MessageDetail/MessageDetailsHeader.tsx 100.00% <100.00%> (ø)
...es/components/MessageDetail/OrganizationHeader.tsx 93.33% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a22d8c7...c444c3e. Read the comment docs.

@Vangaorth Vangaorth changed the title fix: [IOCOM-2160] Service link accessibility role in message details fix: [IOCOM-2160] Service button accessibility role in message details Feb 26, 2025
@Vangaorth Vangaorth marked this pull request as ready for review February 26, 2025 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant