Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOPLT-981] Add dark mode version to some IDP logos #6750

Open
wants to merge 78 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Feb 24, 2025

Caution

This PR depends on some changes that need to be made to io-services-metadata. The following changes only affect the loading behavior of local IDPs.

Short description

This PR adds the dark mode version to some local IDP logos.

List of changes proposed in this pull request

  • Add a dark mode version to the IDPs that have a logo that doesn't work (visually) on dark backgrounds
  • Add a local SpidIdp type that partially overwrites the generated one, while waiting for the definitive one from io-services-metadata
    • Until the two types are perfectly matched, TS errors are generated
  • Update Infocert assets for both color schemes

Preview

dark-mode-idps.mp4

Acknowledgements

@Ladirico

How to test

If you want to test local IDPs without pointing at the remote ones:

  1. Go to the IdpSelectionScreen
  2. At line 88, change the line to const idpValue = idpsFallback
  3. Comment the lines from line 115 to line 122
  4. Launch the app, change the color scheme and log out, as shown in the video above

Copy link
Contributor

github-actions bot commented Feb 24, 2025

Jira Pull Request Link

This Pull Request refers to Jira issues:

Copy link
Contributor

PR Title Validation for conventional commit type

All good! PR title follows the conventional commit type.

Base automatically changed from IOAPPX-458-enable-new-ui to master February 25, 2025 10:50
@codecov codecov bot requested a review from thisisjp as a code owner February 25, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants