-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-2032] Add collapsible credential claims in RP trust screen #6749
base: master
Are you sure you want to change the base?
Conversation
Jira Pull Request LinkThis Pull Request refers to Jira issues: |
PR Title Validation for conventional commit type✅ All good! PR title follows the conventional commit type. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6749 +/- ##
==========================================
+ Coverage 41.94% 50.74% +8.80%
==========================================
Files 1429 1577 +148
Lines 29960 32582 +2622
Branches 6662 7288 +626
==========================================
+ Hits 12566 16535 +3969
+ Misses 17364 16004 -1360
- Partials 30 43 +13
... and 430 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
<Alert | ||
variant="info" | ||
content={I18n.t( | ||
"features.itWallet.presentation.selectiveDisclosure.optionalClaimsAlert" | ||
)} | ||
/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to the design, we should hide this alert if all optional claims are selected. Am I right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems so, but I think there are discrepancies in the design: see here.
However there is a bit of uncertainty about optional claims if we consider the DQCL specs, that do not provide an explicit way to mark claims as optional. I think we're inevitably going to rework this screen in the future, so I'd leave it like this if you agree.
Short description
This PR adds collapsible claim lists grouped by credentials in the Relying Party's trust screen.
List of changes proposed in this pull request
ClaimsSelector
fromio-app-design-system
ItwRequestedClaimsList
and removed those components superseded byClaimsSelector
Note
This section uses several mock parts as the full presentation flow is not yet implemented.
How to test
Go to IT Wallet playground and navigate to the Remote Presentation trust screen.
android.mp4