Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(IT Wallet): [SIW-1743] Display upcoming ITWallet banner for users not yet enabled #6283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

RiccardoMolinari95
Copy link
Collaborator

Short description

This PR introduces a banner for users who have not yet been enabled for ITWallet. Clicking on the banner will direct users to the https://io.italia.it/documenti-su-io page, which is not yet ready at the time of this PR's development

SubscriptionStateEnum.UNSUBSCRIBED || SubscriptionStateEnum.SUBSCRIBED

Screen.Recording.2024-10-15.at.09.16.16.mov

SubscriptionStateEnum.DISABLED

Screenshot 2024-10-15 at 09 24 55

SubscriptionStateEnum.ACTIVE

Screenshot 2024-10-15 at 09 28 55

List of changes proposed in this pull request

  • Updated the banner style to ensure consistency with the rendering of other banners as ItwDiscoveryBanner
  • Created new test file ItwUpcomingWalletBanner.test.tsx to verify the banner's visibility for all combinations of ITWallet enablement (enabled/disabled) and trial system states (ACTIVE, DISABLED, UNSUBSCRIBED, SUBSCRIBED)

How to test

It is possible to test the new ITWallet upcoming banner in two ways:

  • using the test environment (io-dev-api-server) and changing the Trial system response in all the various states (ACTIVE, DISABLED, UNSUBSCRIBED, SUBSCRIBED) and see if the banner is displayed in the states UNSUBSCRIBED and SUBSCRIBED
  • Using the new test created ItwUpcomingWalletBanner.test.tsx

@RiccardoMolinari95 RiccardoMolinari95 requested a review from a team as a code owner October 15, 2024 09:25
@RiccardoMolinari95 RiccardoMolinari95 self-assigned this Oct 15, 2024
@pagopa-github-bot pagopa-github-bot changed the title [SIW-1743] Display upcoming ITWallet banner for users not yet enabled chore(IT Wallet): [SIW-1743] Display upcoming ITWallet banner for users not yet enabled Oct 15, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 15, 2024

Affected stories

  • ⚙️ SIW-1743: Inserimento del link alla nuova sez. sito nel banner rivolto ai non abilitati

Generated by 🚫 dangerJS against e59c713

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.18%. Comparing base (4f204b4) to head (e59c713).
Report is 594 commits behind head on master.

Files with missing lines Patch % Lines
...llet/common/components/ItwUpcomingWalletBanner.tsx 90.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6283      +/-   ##
==========================================
- Coverage   48.42%   47.18%   -1.24%     
==========================================
  Files        1488     1794     +306     
  Lines       31617    36244    +4627     
  Branches     7669     8592     +923     
==========================================
+ Hits        15311    17103    +1792     
- Misses      16238    19083    +2845     
+ Partials       68       58      -10     
Files with missing lines Coverage Δ
...ures/newWallet/components/WalletCardsContainer.tsx 97.87% <ø> (+8.98%) ⬆️
...llet/common/components/ItwUpcomingWalletBanner.tsx 92.85% <90.00%> (ø)

... and 1408 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bff84f1...e59c713. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants