-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-394] Replace GradientScrollView
with IOScrollView
in the Wallet home screen
#6279
base: master
Are you sure you want to change the base?
Conversation
GradientScrollView
with IOScrollView
in the Wallet home screenGradientScrollView
with IOScrollView
in the Wallet home screen
Affected stories
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6279 +/- ##
==========================================
- Coverage 48.42% 47.10% -1.33%
==========================================
Files 1488 1797 +309
Lines 31617 36330 +4713
Branches 7669 8607 +938
==========================================
+ Hits 15311 17113 +1802
- Misses 16238 19160 +2922
+ Partials 68 57 -11
... and 1413 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
This PR replaces the legacy
GradientScrollView
with the newIOScrollView
in the Wallet home screen. This change slightly improves the scrolling behaviour and adds support for dark mode.Preview (with debug mode enabled for demo purposes)
gradient-scrollview-debugmode.mp4
ioscrollview-debugmode.mp4
How to test
Go to the Wallet home screen with dark mode enabled