Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-394] Replace GradientScrollView with IOScrollView in the Wallet home screen #6279

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 11, 2024

Short description

This PR replaces the legacy GradientScrollView with the new IOScrollView in the Wallet home screen. This change slightly improves the scrolling behaviour and adds support for dark mode.

Preview (with debug mode enabled for demo purposes)

Before After
gradient-scrollview-debugmode.mp4
ioscrollview-debugmode.mp4

How to test

Go to the Wallet home screen with dark mode enabled

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter Dark mode 🌝 labels Oct 11, 2024
@dmnplb dmnplb requested a review from a team as a code owner October 11, 2024 14:01
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-394] Replace GradientScrollView with IOScrollView in the Wallet home screen chore(Cross): [IOAPPX-394] Replace GradientScrollView with IOScrollView in the Wallet home screen Oct 11, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 11, 2024

Affected stories

  • ⚙️ IOAPPX-394: [Wallet] Sostituzione di GradientScrollView con IOScrollView
    subtask of

Generated by 🚫 dangerJS against 4ae045e

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.10%. Comparing base (4f204b4) to head (4ae045e).
Report is 595 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6279      +/-   ##
==========================================
- Coverage   48.42%   47.10%   -1.33%     
==========================================
  Files        1488     1797     +309     
  Lines       31617    36330    +4713     
  Branches     7669     8607     +938     
==========================================
+ Hits        15311    17113    +1802     
- Misses      16238    19160    +2922     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
ts/features/newWallet/screens/WalletHomeScreen.tsx 87.50% <ø> (+3.28%) ⬆️

... and 1413 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98bffa7...4ae045e. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Dark mode 🌝 Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants