chore: [IOBP-616] Add missing parameters to payment's calculateFees request payload
#5667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
calculateFees request payloadcalculateFees request payload
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5667 +/- ##
==========================================
- Coverage 48.31% 48.31% -0.01%
==========================================
Files 1466 1466
Lines 31114 31118 +4
Branches 7559 7559
==========================================
Hits 15034 15034
- Misses 16011 16015 +4
Partials 69 69
Continue to review full report in Codecov by Sentry.
|
forrest57
reviewed
Apr 11, 2024
…ncano-alcuni-campi-nella-richiesta-calculate-fees
mastro993
force-pushed
the
IOBP-616-durante-il-flusso-di-pagamento-mancano-alcuni-campi-nella-richiesta-calculate-fees
branch
from
9cc4c6e
to
82ffe1a
Compare
…ncano-alcuni-campi-nella-richiesta-calculate-fees
…ncano-alcuni-campi-nella-richiesta-calculate-fees
forrest57
approved these changes
Apr 12, 2024
mastro993
deleted the
IOBP-616-durante-il-flusso-di-pagamento-mancano-alcuni-campi-nella-richiesta-calculate-fees
branch
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
… request payload (#5667) ## Short description This PR adds `isAllCCP` and `primaryCreditorInstitution` parameters to the payment's `calculateFees` request payload ## List of changes proposed in this pull request - Updated pagoPA payments and wallet API definitions - Added `isAllCCP` and `primaryCreditorInstitution` to calculateFees request payload ## How to test In UAT environment, try to make a payment. You should be able to see the PSP list --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it> Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com>
CrisTofani
pushed a commit
that referenced
this pull request
Apr 12, 2024
… request payload (#5667) ## Short description This PR adds `isAllCCP` and `primaryCreditorInstitution` parameters to the payment's `calculateFees` request payload ## List of changes proposed in this pull request - Updated pagoPA payments and wallet API definitions - Added `isAllCCP` and `primaryCreditorInstitution` to calculateFees request payload ## How to test In UAT environment, try to make a payment. You should be able to see the PSP list --------- Co-authored-by: Mario Perrotta <mario.perrotta@pagopa.it> Co-authored-by: Martino Cesari Tomba <60693085+forrest57@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds
isAllCCPandprimaryCreditorInstitutionparameters to the payment'scalculateFeesrequest payloadList of changes proposed in this pull request
isAllCCPandprimaryCreditorInstitutionto calculateFees request payloadHow to test
In UAT environment, try to make a payment. You should be able to see the PSP list