-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-249] Update build.gradle
#5512
chore(Cross): [IOAPPX-249] Update build.gradle
#5512
Conversation
build.gradle
build.gradle
Affected stories
|
build.gradle
build.gradle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5512 +/- ##
=======================================
Coverage 47.92% 47.92%
=======================================
Files 1424 1424
Lines 30868 30868
Branches 7484 7484
=======================================
Hits 14794 14794
Misses 16015 16015
Partials 59 59 Continue to review full report in Codecov by Sentry.
|
@LazyAfternoons PR LGTM we can merge it directly into the rn upgrade branch to deliver it together in the main branch, what do you think? |
Up to you! I opened a different PR to avoid adding other changes in the react-native upgrade PR because they are not really related to the 0.69 -> 0.70 upgrade, hence it might be different to track them down in case of issues (even in the future). We can merge it and document these changes in your PR description if you want. Thanks. |
@LazyAfternoons ok let's wait! |
🎉 All dependencies have been resolved ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Warning
Depends on #5506
Short description
This PR updates the
build.gradle
file and removes a few workarounds which are not needed anymore after the upgrade to RN 0.70.List of changes proposed in this pull request
exclusiveContent
section, added in this PR to address an issue withreact-native
. Patched for version >0.63
as indicated in the related issue.mavenLocal()
repository which doesn't appear to be included by default in thebuild.gradle
since a fewreact-native
version;configurations.all
section which was added by this PR for a dependency,react-native-camera
, which we don't use anymore.How to test
We should be able to build Android. Test it by running: