Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-249] Update build.gradle #5512

Merged
merged 71 commits into from
Mar 12, 2024

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Feb 14, 2024

Warning

Depends on #5506

Short description

This PR updates the build.gradle file and removes a few workarounds which are not needed anymore after the upgrade to RN 0.70.

List of changes proposed in this pull request

  • Removes exclusiveContent section, added in this PR to address an issue with react-native. Patched for version >0.63 as indicated in the related issue.
  • Removes mavenLocal() repository which doesn't appear to be included by default in the build.gradle since a few react-native version;
  • Removes configurations.all section which was added by this PR for a dependency, react-native-camera, which we don't use anymore.

How to test

We should be able to build Android. Test it by running:

cd android && ./gradlew clean && cd .. 
yarn run-android 

@LazyAfternoons LazyAfternoons changed the base branch from master to IOPLT-342-react-native-upgrade February 14, 2024 13:50
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-249] Remove workarounds in build.gradle chore(Cross): [IOAPPX-249] Remove workarounds in build.gradle Feb 14, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Feb 14, 2024

Affected stories

Generated by 🚫 dangerJS against e135942

@LazyAfternoons LazyAfternoons changed the title chore(Cross): [IOAPPX-249] Remove workarounds in build.gradle chore(Cross): [IOAPPX-249] Update build.gradle Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.92%. Comparing base (033eec2) to head (e135942).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5512   +/-   ##
=======================================
  Coverage   47.92%   47.92%           
=======================================
  Files        1424     1424           
  Lines       30868    30868           
  Branches     7484     7484           
=======================================
  Hits        14794    14794           
  Misses      16015    16015           
  Partials       59       59           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 033eec2...e135942. Read the comment docs.

@LazyAfternoons LazyAfternoons marked this pull request as ready for review February 14, 2024 15:15
@LazyAfternoons LazyAfternoons requested a review from a team as a code owner February 14, 2024 15:15
@CrisTofani
Copy link
Contributor

@LazyAfternoons PR LGTM we can merge it directly into the rn upgrade branch to deliver it together in the main branch, what do you think?

@LazyAfternoons
Copy link
Contributor Author

LazyAfternoons commented Feb 14, 2024

@LazyAfternoons PR LGTM we can merge it directly into the rn upgrade branch to deliver it together in the main branch, what do you think?

Up to you! I opened a different PR to avoid adding other changes in the react-native upgrade PR because they are not really related to the 0.69 -> 0.70 upgrade, hence it might be different to track them down in case of issues (even in the future). We can merge it and document these changes in your PR description if you want. Thanks.

@CrisTofani
Copy link
Contributor

@LazyAfternoons ok let's wait!

Base automatically changed from IOPLT-342-react-native-upgrade to master March 12, 2024 11:03
@CrisTofani CrisTofani requested a review from dmnplb as a code owner March 12, 2024 11:03
Copy link

dpulls bot commented Mar 12, 2024

🎉 All dependencies have been resolved !

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LazyAfternoons LazyAfternoons merged commit 51ce2d0 into master Mar 12, 2024
8 checks passed
@LazyAfternoons LazyAfternoons deleted the IOAPPX-249-remove-workaround-buildgradle branch March 12, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants