-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-217] Add NativeStackNavigator
to the Design System section
#5424
chore(Cross): [IOAPPX-217] Add NativeStackNavigator
to the Design System section
#5424
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5424 +/- ##
==========================================
- Coverage 48.31% 48.17% -0.15%
==========================================
Files 1466 1461 -5
Lines 31114 30959 -155
Branches 7559 7518 -41
==========================================
- Hits 15034 14913 -121
+ Misses 16011 15978 -33
+ Partials 69 68 -1
... and 43 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As for the bug I'd reported, I don't see it anymore ✅
Demo |
---|
-.okay.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Note
This PR depends on #5415
Caution
This PR causes some issues to the
RootModal
component, as pointed out by @shadowsheep1: #5415 (review)Short description
This PR adds the new
NativeStackNavigator
to the Design System section. This change enables a true native modal behaviour on iOS (including pull down to dismiss), other than a native navigation on both platforms.List of changes proposed in this pull request
createNativeStackNavigator
to create the native navigator6.x
versionreact-native-screens
@react-navigation/native-stack
packagePreview
design-system-native-navigation.mp4
How to test
Launch the local app and go to the Design System section