Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-217] Add NativeStackNavigator to the Design System section #5424

Merged
merged 51 commits into from
Apr 11, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Jan 23, 2024

Note

This PR depends on #5415

Caution

This PR causes some issues to the RootModal component, as pointed out by @shadowsheep1: #5415 (review)

Short description

This PR adds the new NativeStackNavigator to the Design System section. This change enables a true native modal behaviour on iOS (including pull down to dismiss), other than a native navigation on both platforms.

List of changes proposed in this pull request

  • Use createNativeStackNavigator to create the native navigator
  • Remove previously nested navigator thanks to the new API offered by the 6.x version
  • Update react-native-screens
  • Add the new @react-navigation/native-stack package

Preview

design-system-native-navigation.mp4

How to test

Launch the local app and go to the Design System section

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 48.17%. Comparing base (9f72690) to head (ba1cf49).
Report is 12 commits behind head on master.

❗ Current head ba1cf49 differs from pull request most recent head ebcc7e7. Consider uploading reports for the commit ebcc7e7 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5424      +/-   ##
==========================================
- Coverage   48.31%   48.17%   -0.15%     
==========================================
  Files        1466     1461       -5     
  Lines       31114    30959     -155     
  Branches     7559     7518      -41     
==========================================
- Hits        15034    14913     -121     
+ Misses      16011    15978      -33     
+ Partials       69       68       -1     
Files Coverage Δ
...ures/bonus/common/screens/AvailableBonusScreen.tsx 8.92% <ø> (ø)
ts/features/design-system/DesignSystem.tsx 34.78% <ø> (ø)
ts/features/fci/hooks/useFciNoSignatureFields.tsx 52.94% <ø> (ø)
ts/features/fci/navigation/FciStackNavigator.tsx 75.00% <ø> (ø)
...eatures/fci/screens/valid/FciDataSharingScreen.tsx 70.45% <ø> (ø)
...eatures/fci/screens/valid/FciQtspClausesScreen.tsx 71.11% <ø> (ø)
...features/messages/navigation/MessagesNavigator.tsx 15.38% <ø> (ø)
...res/messages/screens/LegacyMessageDetailScreen.tsx 8.33% <ø> (ø)
ts/features/pn/components/MessageDetails.tsx 90.00% <ø> (+2.50%) ⬆️
ts/features/pn/navigation/navigator.tsx 18.18% <ø> (ø)
... and 5 more

... and 43 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7829b38...ebcc7e7. Read the comment docs.

Copy link
Member

@shadowsheep1 shadowsheep1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for the bug I'd reported, I don't see it anymore ✅

Demo
-.okay.mov

Copy link
Contributor

@CrisTofani CrisTofani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmnplb dmnplb merged commit 1c2f8c5 into master Apr 11, 2024
11 checks passed
@dmnplb dmnplb deleted the IACROSS-217-remove-nested-navigator-design-system branch April 11, 2024 12:39
@CrisTofani CrisTofani restored the IACROSS-217-remove-nested-navigator-design-system branch April 12, 2024 16:05
CrisTofani added a commit that referenced this pull request Apr 12, 2024
@dmnplb dmnplb removed the keep open label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants