[IOAPPX-281] Add VStack and HStack components
#241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrisTofani
requested changes
Apr 8, 2024
@CrisTofani Addressed in this commit → 53d4e5d |
CrisTofani
approved these changes
Apr 9, 2024
dmnplb
added a commit
that referenced
this pull request
Aug 26, 2024
… the new `HStack` and `VStack` components (#303) >[!caution] > This PR depends on the following PR. **Do not merge the PR beforehand, otherwise it might break part of the UI**. > * pagopa/io-app#5864 ## Short description This PR refactors `Modules…` and `NumberPad` components to take advantage of the new `HStack` and `VStack` components. ## List of changes proposed in this pull request - Update `NumberPad` and `CodeInput` to replace the logic using `VSpacer` and `HSpacer` - Update all the `Modules…` components (both interactive and skeleton states) using `HStack` and `VStack` - Refactor `HStack` and `VStack` to apply some specific style properties (`alignItems`, `flexShrink`, etc…) ### Related PRs * #241 * #297 ## How to test 1. Launch the example app 2. First, check **Numberpad** screen 3. Second, check **Modules** screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The new
VStackandHStackcomponents are only compatible with RN0.71and higher. Theio-apprepository currently uses the0.70version, so these components don't work yet.Short description
This PR adds the new
VStackandHStackcomponents, useful when you need a uniform spacing between other components.List of changes proposed in this pull request
VStackandHStackcomponentsLayoutscreen in the example to show the new componentsPreview
How to test