Show full header h1 for smaller displays #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefix "./" would be lost in mobile displays and when the browser viewport is smaller than the container width. This removes the left margin from the header for smaller displays. Also adds a scss variable so that its easy to change the point where the "mobil" margin is applied.
|
Welcome! Congrats on your first pull request to The Hacker Theme. If you haven't already, please be sure to check out the contributing guidelines. |
|
Congrats on getting your first pull request to The Hacker Theme merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header h1 before "./ " would be lost in mobile displays and/or when the browser viewport is smaller than the container width as the header has negative left margin for the "./ " text.
This pr removes the left margin from the header for smaller displays. Also adds a scss variable
so that its easy to change the point where the margin is applied.
Before:
And with longer header text even the next line of the header is too much on the left:
After:
And with longer header text:
Does not affect the layout if window size is larger than container max-width.