Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdjustByAngleLimit is not working properly #99

Closed
dopieters opened this issue Aug 8, 2023 · 1 comment
Closed

AdjustByAngleLimit is not working properly #99

dopieters opened this issue Aug 8, 2023 · 1 comment

Comments

@dopieters
Copy link

I have noticed that the function AdjustByAngleLimit in AnimNode_KawaiiPhysics.cpp is not working properly. The bug seems to be due to the use of the function RotateAngleAxis which rotate around a normalized vector. Currently the vector is not normalized. So it can be fixed by changing BoneDir = BoneDir.RotateAngleAxis(-AngleOverLimit, Axis); by:

const FVector AxisNormalized = Axis.GetSafeNormal();
BoneDir = BoneDir.RotateAngleAxis(-AngleOverLimit, AxisNormalized);
@pafuhana1213
Copy link
Owner

Hi @dopieters !
I'm appreciate your report and great modified code!

I've committed 9a0576c to fix this issue now.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants