issue with HTML5 tags in IE 7/8 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the bug report and the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to use an HTML5 tag (like
<mark>) as a wrapping node, the result will be broken in IE 7/8 due tocloneNode()inside the_genReplacerfunction. IE has a buggy interpretation of this method and returns<:mark>instead (even with html5shim script enabled) - see http://bugs.jquery.com/ticket/6485 as as ref.The bugs affects both ways of passing a node into the findAndReplaceDOMText function - as a node name and as a stenilNode.
The solution is to clone the node manually, like here http://pastie.org/935834
Pull request attached