feat: add support for opentofu #328
Conversation
LucasMrqes
force-pushed
the
feat/opentofu-support
branch
from
eb00fc3
to
fa5d310
Compare
| { | ||
| "OverrideRepositoryWithLayer", | ||
| &configv1alpha1.TerraformRepository{ | ||
| Spec: configv1alpha1.TerraformRepositorySpec{ | ||
| OpenTofuConfig: configv1alpha1.OpenTofuConfig{ | ||
| Version: "1.0.1", | ||
| }, | ||
| }, | ||
| }, | ||
| &configv1alpha1.TerraformLayer{}, | ||
| "1.0.1", | ||
| }, |
There was a problem hiding this comment.
I think this is a duplicate of OnlyRepositoryVersion.
The "correct" OverrideRepositoryWithLayer is a few lines below.
| OpenTofuConfig OpenTofuConfig `json:"opentofu,omitempty"` | ||
| TerragruntConfig TerragruntConfig `json:"terragrunt,omitempty"` |
There was a problem hiding this comment.
We must remember to put these changes as breaking in the next release
| ExecPath: filepath.Join(binaryPath, "OpenTofu", baseExecVersion, "tofu"), | ||
| } | ||
| } else { | ||
| return nil, errors.New("Please enable either Terraform or OpenTofu in the repository or layer configuration") |
There was a problem hiding this comment.
If an user forgets to enable Terraform or OpenTofu in their CRDs, it would be better to be informed before a runner is spawned.
It can be more intuitive to the user (searching through runner logs is not obvious), maybe it can be checked by the Layer controller or the Run controller ?
| Terraform *terraform.Terraform | ||
| OpenTofu *opentofu.OpenTofu |
There was a problem hiding this comment.
I think we can abstract the tool used to have only one property. For Terragrunt, we only need the execution path of the tool.
I see 2 solutions:
- We add another function to the
TerraformExecinterface to obtain the execution path of the tool - We just give a string
BaseToolPathto theTerragruntstruct instead of a pointer to an object
|
Overall very great Pull Request! 👏 |
This makes it possible to use opentofu instead of terraform. It involves some CRD modifications:
spec.terraform.enabledandspec.terragrunt.enabledTodo: