Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datastore): datastore S3 use path style configuration #322

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

seboudry
Copy link
Contributor

@seboudry seboudry commented Sep 6, 2024

Allow configuration of path style option on AWS S3 SDK.

This allow usage of S3 compatible solutions other than AWS S3.

@AlanLonguet
Copy link
Collaborator

Thanks for testing this and contributing !

@AlanLonguet
Copy link
Collaborator

@seboudry Can you just amend your commit message following the conventional commit standard ?

@seboudry seboudry changed the title datastore S3 use path style configuration feat(datastore): datastore S3 use path style configuration Sep 10, 2024
@seboudry
Copy link
Contributor Author

hop updated

@AlanLonguet AlanLonguet merged commit 10ebe5b into padok-team:main Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants