Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitlab): correctly handle GitLab MR events #178

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Conversation

corrieriluca
Copy link
Member

@corrieriluca corrieriluca commented Oct 21, 2023

Changes

Bug fixes ⚠️

  • Use object_attributes.iid for MR id instead of object_attributes.id since GitLab API needs merge_request_iid in all MR related API calls.

Enhancements

Changes tested in GitLab SaaS 16.6

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2023

Codecov Report

Merging #178 (e06fb7b) into main (0d0cd65) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   70.50%   70.61%   +0.10%     
==========================================
  Files          28       28              
  Lines        1926     1926              
==========================================
+ Hits         1358     1360       +2     
+ Misses        492      490       -2     
  Partials       76       76              
Files Coverage Δ
internal/webhook/gitlab/provider.go 75.00% <100.00%> (+3.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@corrieriluca corrieriluca changed the title fix(webhook): correctly read gitlab MR id fix(gitlab): correctly handle GitLab MR webhooks Oct 21, 2023
@corrieriluca corrieriluca changed the title fix(gitlab): correctly handle GitLab MR webhooks fix(gitlab): correctly handle GitLab MR events Oct 21, 2023
@corrieriluca corrieriluca marked this pull request as ready for review October 21, 2023 15:57
AlanLonguet
AlanLonguet previously approved these changes Oct 23, 2023
@AlanLonguet AlanLonguet merged commit 721fc23 into main Oct 23, 2023
@corrieriluca corrieriluca deleted the fix/gitlab-mr branch October 23, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants