Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(manifests): improve manifest generation #105

Merged
merged 9 commits into from
May 2, 2023
Merged

chore(manifests): improve manifest generation #105

merged 9 commits into from
May 2, 2023

Conversation

corrieriluca
Copy link
Member

@corrieriluca corrieriluca commented Apr 23, 2023 •
edited
Loading

Fixes #68

Changes introduced

  • The manifests files required for installing Burrito have been splitted into multiple Kustomization folders
  • The make manifests command outputs generated CRDs in the manifests/crds dir and then calls Kustomize to generate the plain manifests/install.yaml file
  • The ghcr-creds image pull secret is not used anymore in the manifests
  • The config folder has been deleted as not needed anymore
  • Empty ConfigMaps have been made for Burrito Server and Controllers, as well as a Secret for Webhooks, these are binded as optional in the Pod specs
  • The check-codegen CI job has been added, and fails if manifests needs to be generated again

To do before merging

  • Make ghcr.io/padok-team/burrito public
  • Make a workflow to change the tag for the ghcr.io/padok-team/burrito image the manifests/base/kustomization.yaml when new tags are published

spoukke
spoukke reviewed Apr 24, 2023
View reviewed changes
Copy link
Contributor

@spoukke spoukke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good. @Alan-pad we should try the newly generated install.yaml to check that everything still works properly

.github/workflows/ci.yaml Show resolved Hide resolved
manifests/base/config/burrito-controllers-cm.yaml Outdated Show resolved Hide resolved
manifests/base/config/burrito-server-cm.yaml Outdated Show resolved Hide resolved
manifests/base/config/burrito-webhook-secret.yaml Outdated Show resolved Hide resolved
manifests/base/config/burrito-server-cm.yaml Outdated Show resolved Hide resolved
manifests/base/server/deployment.yaml Outdated Show resolved Hide resolved
manifests/base/server/deployment.yaml Outdated Show resolved Hide resolved
@spoukke spoukke merged commit 63acc4d into main May 2, 2023
Thibaut-Padok pushed a commit that referenced this pull request May 2, 2023
@corrieriluca @spoukke @Thibaut-Padok
chore(manifests): improve manifest generation (#105)
c4cb8f2 
* chore(manifests): apply kustomize after CRD generation

* chore(manifests): delete config/ folder

* chore(manifests): simplify manifest filenames

* chore(manifests): add ConfigMap and Secret for server & controllers

* chore(ci): add check-codegen job

* chore(manifests): regen manifests with controller-gen 0.11.2

* chore(manifests): add proper labels on configmaps and secret

* chore(manifests): pass burrito-webhook-secret as envFrom

* chore: use common cm and generic secret

---------

Co-authored-by: spoukke <sacha.bernheim@hey.com>
@corrieriluca corrieriluca deleted the feat/manifest-generation branch August 2, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spoukke spoukke spoukke approved these changes

@Alan-pad Alan-pad Awaiting requested review from Alan-pad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve manifests generation
2 participants
@corrieriluca @spoukke