-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gRPC): defining network and peers info response's properly #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 83.52% 83.42% -0.10%
==========================================
Files 173 173
Lines 8787 8815 +28
==========================================
+ Hits 7339 7354 +15
- Misses 1098 1108 +10
- Partials 350 353 +3 |
themantre
reviewed
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR doesn't help much. Explain why we need to add these 3 more APIs to the network?
kehiy
changed the title
feat(gRPC): defining network and peers info response properly
feat(gRPC): defining network and peers info response's properly
Jan 2, 2024
b00f
reviewed
Jan 3, 2024
b00f
reviewed
Jan 3, 2024
b00f
reviewed
Jan 3, 2024
b00f
reviewed
Jan 3, 2024
b00f
reviewed
Jan 3, 2024
…ctus into feature/gRPCNetworkInfo
b00f
reviewed
Jan 3, 2024
b00f
approved these changes
Jan 3, 2024
Co-authored-by: b00f <mostafa.sedaghat@gmail.com>
Co-authored-by: b00f <mostafa.sedaghat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this PR we have our network APIs more well defined. I defined a Network name also as a network API.
Our gRPC methods for network have we have (network and node info), return more detaild responses and they contain data releated to themselves only.
Example response for network info:
Node info:
Related issue(s)
GetPeerInfo
andGetNetworkInfo
are not well defined #425