Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet, cmd): add support for importing Ed25519 private keys #1584

Merged

Conversation

alidevjimmy
Copy link
Contributor

Description

This PR adds import ed25519 address by private key support to wallet.
no need for specifying private key type while importing.

Related issue(s)

@alidevjimmy alidevjimmy requested a review from b00f November 4, 2024 09:12
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 58.57143% with 58 lines in your changes missing coverage. Please review.

Project coverage is 75.93%. Comparing base (86a8ba9) to head (f6ac076).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
+ Coverage   75.07%   75.93%   +0.85%     
==========================================
  Files         234      235       +1     
  Lines       12156    18197    +6041     
==========================================
+ Hits         9126    13817    +4691     
- Misses       2582     3918    +1336     
- Partials      448      462      +14     

@b00f b00f changed the title feat(wallet): add import ed25519 support fix(wallet, cmd): add support for importing Ed25519 private keys Nov 4, 2024
@b00f b00f merged commit 0c0220e into pactus-project:main Nov 4, 2024
12 of 13 checks passed
@alidevjimmy alidevjimmy deleted the feat/import-address-using-ed25519 branch November 5, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing Ed25519 Private Key for Wallet
2 participants