Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(wallet): set server address on loading wallet #1348

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

b00f
Copy link
Collaborator

@b00f b00f commented Jun 18, 2024

Description

This PR refactors wallet manager and set the server address on loading wallet.

It fixes #1322

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 30.98592% with 49 lines in your changes missing coverage. Please review.

Project coverage is 77.07%. Comparing base (20e991a) to head (ff3eb48).
Report is 32 commits behind head on main.

Current head ff3eb48 differs from pull request most recent head 0a2f72b

Please upload reports for the commit 0a2f72b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1348      +/-   ##
==========================================
+ Coverage   76.05%   77.07%   +1.01%     
==========================================
  Files         206      232      +26     
  Lines       10672    11849    +1177     
==========================================
+ Hits         8117     9133    +1016     
- Misses       2169     2292     +123     
- Partials      386      424      +38     

@b00f b00f force-pushed the refactor-wallet branch from ff3eb48 to 7b24309 Compare June 18, 2024 05:55
@b00f b00f merged commit 3e735e6 into pactus-project:main Jun 18, 2024
10 checks passed
@b00f b00f deleted the refactor-wallet branch June 18, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic when get total account balance
2 participants