Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing list_latest_versions due to loose regex on gem files #170

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Aug 21, 2024

Fixes an issue introduced in #168.

Raised on slack https://pact-foundation.slack.com/archives/C9VHVEDE1/p1724228717621349

<internal:/usr/local/lib/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- pact_broker/client/pacts/list_latest_versions (LoadError)
        from <internal:/usr/local/lib/site_ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
        from /usr/lib/ruby/gems/3.3.0/gems/pact_broker-client-1.76.0/lib/pact_broker/client/cli/pact_commands.rb:44:in `list_latest_pact_versions'
        from /usr/lib/ruby/gems/3.3.0/gems/thor-1.3.1/lib/thor/command.rb:28:in `run'
        from /usr/lib/ruby/gems/3.3.0/gems/thor-1.3.1/lib/thor/invocation.rb:127:in `invoke_command'
        from /usr/lib/ruby/gems/3.3.0/gems/thor-1.3.1/lib/thor.rb:527:in `dispatch'
        from /usr/lib/ruby/gems/3.3.0/gems/thor-1.3.1/lib/thor/base.rb:584:in `start'
        from /usr/lib/ruby/gems/3.3.0/gems/pact_broker-client-1.76.0/lib/pact_broker/client/cli/custom_thor.rb:34:in `start'
        from /usr/lib/ruby/gems/3.3.0/gems/pact_broker-client-1.76.0/bin/pact-broker:10:in `<top (required)>'
        from /usr/bin/pact-broker:25:in `load'
        from /usr/bin/pact-broker:25:in `<main>'

whereby we are excluding files from being included in the gem, however we were looking for any path+filename that includes test which captures lib/pact_broker/client/pacts/list_latest_versions.rb

This change updates the rejection list to only include spec/, test/, .github/.

It also removesfeatures (not sure why I included that before for exclusion)

@YOU54F YOU54F merged commit c5776fc into master Aug 21, 2024
35 checks passed
@YOU54F YOU54F deleted the fix/gem_files_excludes_too_loose branch August 21, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant