Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock rack-test version #181

Closed
wants to merge 1 commit into from
Closed

Unlock rack-test version #181

wants to merge 1 commit into from

Conversation

joshuajaco
Copy link

The version lock for rack-test breaks our bundle since we are using version > 1. pact-ruby also seems to work fine with it.

@bethesque
Copy link
Member

Please see #164

What I'm concerned with is that a request without a content type in the pact will have a content type set by rack test. I don't have time to look into this at the moment, but if you could investigate and let me know your findings, we can get this version upgrade happening more quickly.

@bethesque
Copy link
Member

Any progress on this @joshuajaco?

@RaVbaker
Copy link

When @bethesque are you planning to ship this unlock?

@joshuajaco
Copy link
Author

We are unsure on how to proceed with pact and contract testing in general, I thus don't have time for this at the moment. I will look into it once I find some time.

@cabello
Copy link

cabello commented Feb 4, 2019

This is also affecting us as we use rack-test 1.1.0.

@bethesque
Copy link
Member

I need someone to investigate #181 (comment) before I can merge this.

@cabello
Copy link

cabello commented Feb 5, 2019

How can we test this? From the original PR rack/rack-test#223 with breaking changes I get the sense that non-GET requests always require a content type: multipart, x-www-form-urlencoded or application/json. But one could expect a DELETE for example DELETE /collection/:id to not need a content type, would that be the scenario we are looking to test?

@bethesque
Copy link
Member

Most people should set a content type, but what if someone is testing how the server responds when they don't set a content type? Maybe what I can do is remove the rack version dependency from the ruby version, allowing people to choose which version they want, but then hardcode it in the "standalone" so that there are no changes apparent to other users.

@bethesque
Copy link
Member

Ok, I've set the version to '>= 0.6.3', '< 2.0.0'. Fingers crossed it doesn't cause any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants