Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-driver): use std:process over tokio for plugin loads on al… #69

Merged

Conversation

YOU54F
Copy link
Member

@YOU54F YOU54F commented Jul 17, 2024

…l os

fixes tokio-rs/tokio#3520

Signals do not add SA_ONSTACK which may cause linked Go applications to crash.

fixes #68
fixes pact-foundation/pact-go#269
fixes #73

note: std::process unable to read pact-avro-plugin startup message see #68 for detail

YOU54F added a commit to YOU54F/pact-avro-plugin that referenced this pull request Aug 19, 2024
YOU54F added a commit to YOU54F/pact-avro-plugin that referenced this pull request Aug 19, 2024
@YOU54F YOU54F force-pushed the fix/issue-68_replace_tokio_process branch from a7e0302 to f332bca Compare August 21, 2024 21:57
relates to tokio-rs/tokio#3520

Signals do not add SA_ONSTACK which may cause linked Go applications to crash.

fixes pact-foundation#68
fixes pact-foundation/pact-go#269

windows plugin shutdowns, terminate child processes
@YOU54F
Copy link
Member Author

YOU54F commented Aug 22, 2024

Tested and working in (using an ffi forked release - https://github.com/you54f/pact-reference/releases/tag/libpact_ffi-v0.4.33)

  • pact-go
    • os
      • linux / macos / windows
    • plugins
      • protobuf / csv / avro / matt
  • dotnet
    • os
      • linux / macos / windows
    • plugins
      • protobuf / csv / avro / matt
  • pact-js-core
    • os
      • linux / macos / windows
    • plugins
      • protobuf / matt
  • pact-ruby-ffi
    • os
      • linux / macos / windows
    • plugins
      • protobuf

For avro plugin usage, tested with this PR applied austek/pact-avro-plugin#45

Released a fork https://github.com/austek/pact-avro-plugin/releases/tag/v0.0.6

⚠️ Switching to threads, will cause any usage of the pact-avro-plugin prior to 0.0.6 to fail

@YOU54F
Copy link
Member Author

YOU54F commented Aug 30, 2024

Good to go now, avro plugin is released. pr failures are expected, passing in an branch against origin

https://github.com/pact-foundation/pact-plugins/tree/fix/issue-68_replace_tokio_process

@rholshausen rholshausen merged commit a9080f3 into pact-foundation:main Sep 3, 2024
20 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants