fix: Shut the channel down when the init plugin call fails #14

drivers/jvm/core/src/main/kotlin/io/pact/plugins/jvm/core/PluginManager.kt

@@ -38,7 +38,6 @@ import io.pact.plugin.PactPluginGrpc
 import io.pact.plugin.PactPluginGrpc.newBlockingStub
 import io.pact.plugin.Plugin
 import io.pact.plugins.jvm.core.Utils.fromProtoValue
-import io.pact.plugins.jvm.core.Utils.handleWith
 import io.pact.plugins.jvm.core.Utils.jsonToValue
 import io.pact.plugins.jvm.core.Utils.mapToProtoStruct
 import io.pact.plugins.jvm.core.Utils.structToJson
@@ -881,17 +880,27 @@ object DefaultPluginManager: KLogging(), PluginManager {
   }
 
   private fun tryInitPlugin(plugin: PactPlugin, address: String): Result<PactPlugin, Exception> {
-    return handleWith<PactPlugin> {
+    try {
       val channel = ManagedChannelBuilder.forTarget(address)
         .usePlaintext()
         .build()
       val stub = newBlockingStub(channel).withCallCredentials(BearerCredentials(plugin.serverKey))
       plugin.stub = stub
       plugin.channel = channel
 
-      initPlugin(plugin)
+      try {
+        initPlugin(plugin)
+      } catch (e: Exception) {
+        plugin.stub = null
+        plugin.channel = null
+        channel.shutdownNow()
+        throw e
+      }
 
-      plugin
+      return Result.Ok(plugin)
+    } catch (e: Exception) {
+      logger.error(e) { "Failed to initialise the plugin" }
+      return Result.Err(e)
     }
   }
 
@@ -977,11 +986,11 @@ object DefaultPluginManager: KLogging(), PluginManager {
   }
 
   private fun logLevel() = when {
-    logger.isTraceEnabled -> "trace"
-    logger.isDebugEnabled -> "debug"
-    logger.isInfoEnabled -> "info"
-    logger.isWarnEnabled -> "warn"
-    logger.isErrorEnabled -> "error"
+    logger.isTraceEnabled() -> "trace"
+    logger.isDebugEnabled() -> "debug"
+    logger.isInfoEnabled() -> "info"
+    logger.isWarnEnabled() -> "warn"
+    logger.isErrorEnabled() -> "error"
     else -> ""
   }