Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Compare strings directly #674

Merged
merged 1 commit into from
Oct 2, 2024
Merged

refactor: Compare strings directly #674

merged 1 commit into from
Oct 2, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Oct 2, 2024

Don't let json format interfere in strings comparition.

@tienvx tienvx requested review from JP-Ellis and YOU54F October 2, 2024 06:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11138724946

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.884%
Totals Coverage Status
Change from base Build 11123466899: 0.0%
Covered Lines: 2586
Relevant Lines: 2697
💛 - Coveralls

@tienvx tienvx merged commit cb1b59a into pact-foundation:master Oct 2, 2024
18 checks passed
@tienvx tienvx deleted the compare-strings-directly branch October 2, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis