Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Use PHP 8.0 constructor property promotion feature #642

Merged
merged 1 commit into from
Sep 25, 2024
Merged

refactor: Use PHP 8.0 constructor property promotion feature #642

merged 1 commit into from
Sep 25, 2024

Conversation

tienvx
Copy link
Contributor

@tienvx tienvx commented Sep 24, 2024

For #260

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11019188987

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.342%
Totals Coverage Status
Change from base Build 11019128337: 0.0%
Covered Lines: 2307
Relevant Lines: 2370
💛 - Coveralls

@tienvx tienvx merged commit 30b497a into pact-foundation:master Sep 25, 2024
18 checks passed
@tienvx tienvx deleted the use-php-8.0-constructor-property-promotion-feature branch September 25, 2024 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JP-Ellis JP-Ellis JP-Ellis approved these changes

@YOU54F YOU54F Awaiting requested review from YOU54F

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tienvx @coveralls @JP-Ellis